Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Don't emit invalid code #3302

Merged
merged 19 commits into from
Jan 18, 2022
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 18, 2022

Description:

swc_ecma_minifier:

  • Add lots of debug assertions for invalid codes.
  • Remove all invalid AST nodes eagerly.
  • pure: Normalize PatOrExpr.
  • analyzer: Handle PatOrExpr correctly.

Related issue (if exists):

@kdy1 kdy1 added this to the v1.2.131 milestone Jan 18, 2022
@kdy1 kdy1 changed the title fix(es/minifier): Fix video.js fix(es/minifier): Don't emit invalid code Jan 18, 2022
@kdy1 kdy1 marked this pull request as ready for review January 18, 2022 11:52
@kdy1 kdy1 merged commit 8e796cd into swc-project:main Jan 18, 2022
@kdy1 kdy1 deleted the minifier-next branch January 18, 2022 11:52
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Jan 19, 2022
This PR applies lots of patches, including

 - swc-project/swc#3303
 - swc-project/swc#3301
 - swc-project/swc#3287
 - swc-project/swc#3286
 - swc-project/swc#3289

  - swc-project/swc#3302
    - Fixes #33265

(Verified)

I'll undraft this after verifying
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
nevilm-lt pushed a commit to nevilm-lt/next.js that referenced this pull request Apr 22, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

1 participant